[ 
https://issues.apache.org/jira/browse/PIG-2900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454636#comment-13454636
 ] 

Alan Gates commented on PIG-2900:
---------------------------------

In general it looks good.  I had a couple of questions/comments:

We should add a note to the release notes section of the JIRA noting the new
feature and how the mapping of env var names will be handled (e.g. a.b.c will
be mapped to a_b_c).

It would be nice to have an e2e test that checks that the environment variable 
ends up on the remote side.  I'll take a look at adding that.

The unit test you provided fails on my mac.  It seems dfs_data_dir isn't in the 
created configuration.  A lot of other values are, like hadoop_tmp_dir.  I 
didn't run it on Linux to see if it works ok there.
                
> Streaming should provide conf settings in the environment
> ---------------------------------------------------------
>
>                 Key: PIG-2900
>                 URL: https://issues.apache.org/jira/browse/PIG-2900
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Dmitriy V. Ryaboy
>            Assignee: Dmitriy V. Ryaboy
>         Attachments: PIG-2900.1.patch, PIG-2900.patch
>
>
> Hadoop Streaming converts jobconf properties into environment variables; Pig 
> streaming does not. This is a useful feature that Pig streaming should 
> provide.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to