----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6884/ -----------------------------------------------------------
(Updated Sept. 28, 2012, 8:44 p.m.) Review request for pig and Santhosh Srinivasan. Changes ------- After discussing with Santhosh offline, I made changes to type merging as follows: 1) int + float/double = float/double 2) long + float/double = float/double Although this may result in loss of precision, I decided to do so because: 1) This is consistent with how Pig merges numeric types. 2) Converting numeric types to strings (e.g. int + float/double = string) will result in loss of type information, which seems more significant than loss of precision particularly when data producers are different from data consumers. Description ------- Add support for multiple avro schemas to AvroStorage. This patch is based on Stan Rosenberg's original work. Please see https://issues.apache.org/jira/browse/PIG-2579 for details This addresses bug PIG-2579. https://issues.apache.org/jira/browse/PIG-2579 Diffs (updated) ----- contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorage.java d7a004f contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java 84280af contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroInputFormat.java fb5cc25 contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/PigAvroRecordReader.java 75057f9 contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorage.java 1f6e581 contrib/piggybank/java/src/test/java/org/apache/pig/piggybank/test/storage/avro/TestAvroStorageUtils.java 0761d5a Diff: https://reviews.apache.org/r/6884/diff/ Testing ------- New unit tests are added: - TestAvroStorageUtils.testMergeSchema - TestAvroStorage.testMultipleSchemas1,2 Thanks, Cheolsoo Park
