[ 
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Koji Noguchi updated PIG-2975:
------------------------------

    Attachment: pig-2975-trunk_v02-broken.txt

(This patch is broken. Not intended for commit)

bq. Another option, of course, is changing the raw Comparator. We could instead 
use PigTupleDefaultRawComparator once we unwrap a layer.

Tried to shortcut by extending NullableTuple. This patch does fix the two 
issues but introduce an extra layer of Tuple for outputs.

{noformat}
$ cat test/order.txt
3
222
1
222222222222...222 (repeat more than 256 time)
53
$ cat test/order.pig
a = load 'test/order.txt' as (a1:bytearray);
b = order a by a1;
dump b;

$ pig -x local test/order.pig 
((1))
((2))
((222))
((222222222222...222))
((3))
((4))
((53))
((99))
{noformat}

I want getValueAsPigType to return Tuple for sorting comparisons but actual 
value within Tuple for others... Still thinking. 
                
> TestTypedMap.testOrderBy failing with incorrect result 
> -------------------------------------------------------
>
>                 Key: PIG-2975
>                 URL: https://issues.apache.org/jira/browse/PIG-2975
>             Project: Pig
>          Issue Type: Sub-task
>    Affects Versions: 0.11
>            Reporter: Koji Noguchi
>            Assignee: Koji Noguchi
>            Priority: Blocker
>             Fix For: 0.11
>
>         Attachments: pig-2975-trunk_v01.txt, pig-2975-trunk_v02-broken.txt
>
>
> Looked at 
> {noformat}
> junit.framework.AssertionFailedError
>     at org.apache.pig.test.TestTypedMap.testOrderBy(TestTypedMap.java:352)
> {noformat}
> This looks like a valid test case failing with incorrect result.
> {noformat}
> % cat test/orderby.txt
> [key#1,key9#23]
> [key#3,key3#2]
> [key#22]
> % cat test/orderby.pig
> a = load 'test/orderby.txt' as (m:[]);
> b = foreach a generate m#'key' as b0;
> dump b;
> c = order b by b0;
> dump c;
> % java ... org.apache.pig.Main    -x local test/orderby.pig 
> [dump b]
> (1)
> (3)
> (22)
> ...
> [dump c]
> (1)
> (1)
> (22)
> %
> where did the '(3)' go?
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to