-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7053/
-----------------------------------------------------------
(Updated Oct. 25, 2012, 5:21 p.m.)
Review request for pig and Rohini Palaniswamy.
Changes
-------
Hi, Daniel, Rohini,
I implemented the required optimization which ensures that the local and HDFS
directories are created only when needed (on demand).
These changes are in newly attached "PIG-2898-trunk-7.patch".
The idea of the fix is that we splitted methods #globalSetup() and
#globalCleanup() into 2 parts: new methods #globalSetup2() and #globalClenup2()
methods introduced. The method #globalSetup2() only invoked if there is some
test to execute, and #globalCleanup2() is only invoked if #globalSetup2() was
invoked.
Also in this patch I reverted one of previous changes that changed
IPC::Run::run('mkdir' ...) to "mkpath" perl call because "mkpath" appears to
have (at lest on my perl implementation 5.14.2) quite strange feature: it
returns non-zero exit status with "No such file or directory" message if the
directory we're attempting to create already exists. This behavior is
unexpected and confusing because it contradicts to native "mkdir -p" and
java.io.File#mkdirs() behavior. So, despite of the fact that IPC::Run::run is
slower, I prefer to use it to avoid developer's trouble.
Description
-------
Please see https://issues.apache.org/jira/browse/PIG-2898 for details.
This addresses bug https://issues.apache.org/jira/browse/PIG-2898.
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/PIG-2898
Diffs (updated)
-----
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/TestDriver.pm
1402191
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/harness/test_harness.pl
1402191
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/build.xml 1402191
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/conf/local.conf
1402191
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/deployers/ExistingClusterDeployer.pm
1402191
http://svn.apache.org/repos/asf/pig/trunk/test/e2e/pig/drivers/TestDriverPig.pm
1402191
Diff: https://reviews.apache.org/r/7053/diff/
Testing
-------
Tested e2e tests execution in both sequential (default) and parallel modes.
The test run duration measurement data (in dependency on the fork parameters)
will be available soon.
Thanks,
Ivan Veselovsky
