[
https://issues.apache.org/jira/browse/PIG-2582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485449#comment-13485449
]
Rohini Palaniswamy commented on PIG-2582:
-----------------------------------------
Agree with Bill. It would be good to make them private. Also the getters and
setters were already available and the interface is marked unstable. We can
wait another week to see if anyone disagrees, else we can go ahead with a patch
that makes the member variables private but retains the getter/setter for
mBytes marked deprecated.
setmBytes also needs to set the bytes. If we are making the variables private
we can remove mbytes variable altogether and only retain bytes.
> Store size in bytes (not mbytes) in ResourceStatistics
> ------------------------------------------------------
>
> Key: PIG-2582
> URL: https://issues.apache.org/jira/browse/PIG-2582
> Project: Pig
> Issue Type: Bug
> Reporter: Travis Crawford
> Assignee: Prashant Kommireddi
> Priority: Minor
> Attachments: PIG-2582.patch
>
>
> In
> [ResourceStatistics.java|http://svn.apache.org/viewvc/pig/trunk/src/org/apache/pig/ResourceStatistics.java?view=markup]
> we see mBytes is public, and has a public getter/setter.
> {code}
> 47 public Long mBytes; // size in megabytes
> 196 public Long getmBytes() {
> 197 return mBytes;
> 198 }
> 199 public ResourceStatistics setmBytes(Long mBytes) {
> 200 this.mBytes = mBytes;
> 201 return this;
> 202 }
> {code}
> Typically sizes are stored as bytes, potentially having convenience functions
> to return with different units.
> If mBytes can be marked private without causing woes it might be worth
> storing size as bytes instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
