[ 
https://issues.apache.org/jira/browse/PIG-3025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cheolsoo Park updated PIG-3025:
-------------------------------

    Attachment: PIG-3025.branch-0.10.1-2.patch

+1.

Thank you very much for your contribution!

Although your patch looks good, our indentation convention is to use 4 spaces 
instead of tabs. I am uploading the same patch that includes no tabs. It would 
be nice if you could avoid tabs next time.

Thanks!
                
> TestPruneColumn unit test - SimpleEchoStreamingCommand perl inline script 
> needs simplification
> ----------------------------------------------------------------------------------------------
>
>                 Key: PIG-3025
>                 URL: https://issues.apache.org/jira/browse/PIG-3025
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.10.0
>            Reporter: John Gordon
>            Assignee: John Gordon
>             Fix For: 0.10.1
>
>         Attachments: PIG-3025.branch-0.10.1-2.patch, 
> PIG-3025.branch-0.10.1.patch
>
>
> The "SimpleEchoStreamingCommand" string, which is an inline perl script, is 
> unnecessarily complicated by escaping nested quote characters on the 
> command-line.  As a result, it ends up unstable across shell implementations 
> and operating systems.
> Considering that perl has qq and can print unquoted values, this seems like 
> it is not needed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to