[ 
https://issues.apache.org/jira/browse/PIG-3137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Johnny Zhang updated PIG-3137:
------------------------------

    Attachment: PIG-3137.patch.txt

this patch changes TestDBStorage and TestAvroStorage not use /tmp to store the 
testing data.

It uses the FileLocalizer to gain the temp dir from PigContext. The good side 
about it is user will have fully permission on the dir used by PigServer, so 
test won't fail in case user doesn't have enough permission on /tmp. For 
example, the TestAvroStorage right not using 
$PIG_DIR/contrib/piggybank/java/file:/tmp/temp1371024088/tmp1070213954/TestAvroStorage/
 instead of /tmp/TestAvroStorage to store testing data.

The fix for TestAvroStorage is straightforward, the fix for TestDBStorage is a 
little bit different, since hsqldb doesn't work in minicluster hdfs, we need to 
create another local PigServer to host the hsqldb database.

[~cheolsoo], what do you think about it? Thanks.
                
> fix Piggybank test to not using /tmp dir
> ----------------------------------------
>
>                 Key: PIG-3137
>                 URL: https://issues.apache.org/jira/browse/PIG-3137
>             Project: Pig
>          Issue Type: Bug
>          Components: piggybank
>    Affects Versions: 0.11
>            Reporter: Johnny Zhang
>             Fix For: 0.12
>
>         Attachments: PIG-3137.patch.txt
>
>
> right now several Piggybank tests create directory under /tmp to store test 
> data, the test could fail because user doesn't have permission to create 
> directory under /tmp. It is better to move test data dir under build dir to 
> avoid this problem.
> I will submit a patch soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to