Sandy Ryza created PIG-3160:
-------------------------------

             Summary: GFCross uses unnecessary loop
                 Key: PIG-3160
                 URL: https://issues.apache.org/jira/browse/PIG-3160
             Project: Pig
          Issue Type: Improvement
          Components: internal-udfs
    Affects Versions: 0.10.0
            Reporter: Sandy Ryza


The GFCross UDF contains the following code:

{code}
int[] digits = new int[numInputs];
for (int i=0; i<numInputs; i++){
  if (i == myNumber){
    digits[i] = r.nextInt(numGroupsPerInput);
  }else{
    digits[i] = 0;
 }
}
{code}

As int arrays are initialized with all 0s already, this is equivalent to just 
settings digits[myNumber] and leaving the rest alone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to