----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9481/#review16700 -----------------------------------------------------------
src/org/apache/pig/builtin/ToJson.java <https://reviews.apache.org/r/9481/#comment35417> Hey Russell, you must have missed the apache header? src/org/apache/pig/builtin/ToJson.java <https://reviews.apache.org/r/9481/#comment35418> Is this object used anywhere? You can may be get rid of this if not. src/org/apache/pig/builtin/ToJson.java <https://reviews.apache.org/r/9481/#comment35419> This could probably be constructed lazily only once. Something like ByteArrayOutputStream baos; if(baos == null) { baos = new ByteArrayOutputStream(BUF_SIZE); } src/org/apache/pig/builtin/ToJson.java <https://reviews.apache.org/r/9481/#comment35420> This can also be lazily created (once only)? test/org/apache/pig/test/TestToJson.java <https://reviews.apache.org/r/9481/#comment35421> Looks like the Apache header is in here twice? You have one at the top, this one could be removed. - Prashant Kommireddi On Feb. 17, 2013, 9:47 p.m., Russell Jurney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9481/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2013, 9:47 p.m.) > > > Review request for pig, Ashutosh Chauhan, Dmitriy Ryaboy, Alan Gates, > Jonathan Coveney, and Bill Graham. > > > Description > ------- > > This patch is for JIRA, https://issues.apache.org/jira/browse/PIG-2641 > PIG-2641 - which adds a ToJson builtin based on the serialization in > JsonStorage. > > > This addresses bug PIG-2641. > https://issues.apache.org/jira/browse/PIG-2641 > > > Diffs > ----- > > src/org/apache/pig/builtin/JsonStorage.java 56086ff > src/org/apache/pig/builtin/ToJson.java PRE-CREATION > test/org/apache/pig/test/TestToJson.java PRE-CREATION > test/org/apache/pig/test/data/jsonStorage1.tojson PRE-CREATION > > Diff: https://reviews.apache.org/r/9481/diff/ > > > Testing > ------- > > This works for me locally, and there is a working unit test. > > > Thanks, > > Russell Jurney > >
