Jim Plush created PIG-3242: ------------------------------ Summary: Standardize where TupleFactory is called from in LoadFuncs Key: PIG-3242 URL: https://issues.apache.org/jira/browse/PIG-3242 Project: Pig Issue Type: Improvement Reporter: Jim Plush Priority: Minor
I noticed looking in the PiggyBank LoadFunc classes sometimes there will be cases where the TupleFactory instance is created in the constructor and sometimes there are cases when it's in the getNext() override method. Is there a particular reason for this or can I submit a patch to standardize on using it in the constructor across the Loaders? CSVLoader.java - constructor method private TupleFactory mTupleFactory = TupleFactory.getInstance(); RegExLoader.java - getNext method TupleFactory mTupleFactory = DefaultTupleFactory.getInstance(); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira