[
https://issues.apache.org/jira/browse/PIG-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598580#comment-13598580
]
Prashant Kommireddi commented on PIG-2591:
------------------------------------------
Thanks guys. Here are a couple cases I am thinking about:
1. On Windows machine - java.io.tempdir could default to something like, say
"C:\DOCUME~1\username\LOCALS~1\Temp\". This is fine if we are running unit
tests on a local machine but could have unexpected results when pig attempts to
create that directory on HDFS for intermediate files?
2. Clarity - would it be better to separate these properties as
"pig.test.temp.dir" and "pig.temp.dir"? It might be good (and expected) if we
default pig.temp.dir to "/tmp" as that's been the case always.
Jarcec, I agree on what you propose too. It makes sense to separate the helper
methods into TmpUtil. The patch does not currently use java.io.tmpdir, how do
you see that being used?
> Unit tests should not write to /tmp but respect java.io.tmpdir
> --------------------------------------------------------------
>
> Key: PIG-2591
> URL: https://issues.apache.org/jira/browse/PIG-2591
> Project: Pig
> Issue Type: Bug
> Components: tools
> Reporter: Thomas Weise
> Assignee: Jarek Jarcec Cecho
> Fix For: 0.12
>
> Attachments: bugPIG-2591.patch, PIG-2495.patch
>
>
> Several tests use /tmp but should derive temporary file location from
> java.io.tmpdir to avoid side effects (java.io.tmpdir is already set to a test
> run specific location in build.xml)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
