[ https://issues.apache.org/jira/browse/PIG-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606861#comment-13606861 ]
Daniel Dai commented on PIG-2641: --------------------------------- Looks good. Several minor comments: * Seems it is better to take JsonSerializer out as an independent class * ToJson:30: r is never used, shall we remove this line? * Can we add javadoc to ToJson? And xdoc, since it is in builtin > Create toJSON function for all complex types: tuples, bags and maps > ------------------------------------------------------------------- > > Key: PIG-2641 > URL: https://issues.apache.org/jira/browse/PIG-2641 > Project: Pig > Issue Type: New Feature > Components: piggybank > Affects Versions: 0.12 > Environment: Foggy. Damn foggy. > Reporter: Russell Jurney > Assignee: Russell Jurney > Labels: chararray, fun, happy, input, json, output, pants, pig, > piggybank, string, wonderdog > Fix For: 0.12 > > Attachments: PIG-2641-2.patch, PIG-2641-3.patch, PIG-2641-4.patch, > PIG-2641-5.patch, PIG-2641-6.patch, PIG-2641.patch > > Original Estimate: 96h > Remaining Estimate: 96h > > It is a travesty that there are no UDFs in Piggybanks that, given an > arbitrary Pig datatype, return a JSON string of same. I intend to fix this > problem. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira