[ 
https://issues.apache.org/jira/browse/PIG-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Kommireddi updated PIG-3259:
-------------------------------------

    Description: 
These conversions can be performing better. If the input is not numeric 
(1234abcd) the code calls Double.valueOf(String) regardless before finally 
returning null. Any script that inadvertently (user's mistake or not) tries to 
cast non-numeric column to int or long would result in many wasteful calls. 

We can avoid this and only handle the cases we find the input to be a decimal 
number (1234.56) and return null otherwise even before trying 
Double.valueOf(String).

  was:
These conversions can be performing better. If the input is not numeric 
(1234abcd) the code calls Double.valueOf(String) regardless before finally 
returning null. Any script that inadvertently (user's mistake or not) tries to 
cast alpha-numeric column to int or long would result in many wasteful calls. 

We can avoid this and only handle the cases we find the input to be a decimal 
number (1234.56) and return null otherwise even before trying 
Double.valueOf(String).

    
> Optimize byte to Long/Integer conversions
> -----------------------------------------
>
>                 Key: PIG-3259
>                 URL: https://issues.apache.org/jira/browse/PIG-3259
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.11, 0.11.1
>            Reporter: Prashant Kommireddi
>             Fix For: 0.12
>
>         Attachments: byteToLong.xlsx
>
>
> These conversions can be performing better. If the input is not numeric 
> (1234abcd) the code calls Double.valueOf(String) regardless before finally 
> returning null. Any script that inadvertently (user's mistake or not) tries 
> to cast non-numeric column to int or long would result in many wasteful 
> calls. 
> We can avoid this and only handle the cases we find the input to be a decimal 
> number (1234.56) and return null otherwise even before trying 
> Double.valueOf(String).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to