[
https://issues.apache.org/jira/browse/PIG-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alan Gates updated PIG-3237:
----------------------------
Fix Version/s: (was: 0.10.0)
Status: Open (was: Patch Available)
Thanks for the patch. Some belated feedback.
# Please add some documentation (preferably in the form of javadocs on the
class) explaining what this does. Looking over the code it's not clear to me
what you're trying to accomplish or even how this is related to creating a set.
# It needs unit tests
# You're hard wiring the number of allowed tokens in a couple of places. bits[]
and strings[] both have hard coded values. This will result in
IndexOutOfBoundsExceptions with no error message indicating why. These should
be extensible, or at least check the bounds and tell users they have exceeded
them.
> Pig current releases lack a UDF MakeSet(). This UDF returns a set value (a
> string containing substrings separated by "," characters) consisting of the
> strings that have the corresponding bit in the first argument
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-3237
> URL: https://issues.apache.org/jira/browse/PIG-3237
> Project: Pig
> Issue Type: New Feature
> Affects Versions: 0.10.0
> Reporter: Seethal Vincent
> Attachments: MakeSet.java.patch
>
>
> Pig current releases lack a UDF MakeSet(). This UDF returns a set value (a
> string containing substrings separated by "," characters) consisting of the
> strings that have the corresponding bit in the first argument
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
