[
https://issues.apache.org/jira/browse/PIG-3333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669771#comment-13669771
]
Alan Gates commented on PIG-3333:
---------------------------------
StreamingCommand.addPathToCache - This appears to always convert the path from
/ to \. Don't we only want to do this in the Windows case? Alternatively we
could always convert / and \ to System.getProperties("file.separator").
JavaCompilerHelp.addClassToPath - Rather than if on windows/unix why not just
change it to
{code}
this.classPath = this.classPath+ System.getProperties("path.separator") +path;
{code}
It looks like a bunch of \r's slipped into TestSample.java
> Fix remaining Windows core unit test failures
> ---------------------------------------------
>
> Key: PIG-3333
> URL: https://issues.apache.org/jira/browse/PIG-3333
> Project: Pig
> Issue Type: Sub-task
> Components: impl
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.12
>
> Attachments: PIG-3333-1.patch
>
>
> I combine a bunch of Windows unit test fixes into one patch to make things
> cleaner. They all originated from obvious Windows/Unix inconsistencies, which
> includes:
> 1. Path separator inconsistency: "/" vs "\"
> 2. Path component separator inconsistency: ":" vs ";"
> 3. "volume:" is not acceptable as URI
> 4. Unix tools/commands (eg, bash, rm) does not exist in Windows
> 5. .sh script need a .cmd companion in Windows
> 6. "\r\n" vs "\n" as newline
> 7. Environment variable use different name (USER vs USERNAME)
> 8. File not closed, not an issue in Unix, but an issue in Windows (not able
> to remove a open file)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
