[ 
https://issues.apache.org/jira/browse/PIG-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722536#comment-13722536
 ] 

Jarek Jarcec Cecho commented on PIG-3390:
-----------------------------------------

Thank you for taking a look [~cheolsoo]!

bq. 1. I think you made mistakes in ivy.xml. It doesn't compile.

It seems that I've corrupted the patch during clean up, will fix that. Please 
accept my apologies for the inconvenience. 

bq. 2. Can you change "hbase.version" to "hbase94.version" in 
libraries.properties?

Of course, will do.

bq. 3. Do you mind explaining what these jars are for? Are they needed?

The HBase pom file seems to be corrupted as is not downloading transitive 
dependencies (covered by HBASE-8488). I had to enumerate all dependencies 
myself to overcome that. The HTrace is one of such dependencies.

bq. 4. Let's not add support for hadoop2 yet. We can revisit when hbase jars 
are available. TestHBaseStorage is excluded in hadoop2 unit tests anyway.

Understood, will clean up the patch then.

bq. 5. Can you remove unused imports in TestHbaseStorage.java and 
HbaseStorage.java?

Will do!

bq. 6. Can you use 4-space indentation instead of 2-space?

Will do!

Jarcec
                
> Make pig working with HBase 0.95
> --------------------------------
>
>                 Key: PIG-3390
>                 URL: https://issues.apache.org/jira/browse/PIG-3390
>             Project: Pig
>          Issue Type: New Feature
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>         Attachments: PIG-3390.patch
>
>
> The HBase 0.95 changed API in incompatible way. Following APIs that 
> {{HBaseStorage}} in Pig uses are no longer available:
> * {{Mutation.setWriteToWAL(Boolean)}}
> * {{Scan.write(DataOutput)}}
> Also in addition the HBase is no longer available as one monolithic archive 
> with entire functionality, but was broken down into smaller pieces such as 
> {{hbase-client}}, {{hbase-server}}, ...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to