[
https://issues.apache.org/jira/browse/PIG-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734787#comment-13734787
]
Xuefu Zhang commented on PIG-3414:
----------------------------------
I think using custom code to detect grammar error might not be the best
approach. I can image that there can be more cases like this. Ideally, we
should fix this by the grammar or the use of antlr.
> QueryParserDriver.parseSchema(String) silently returns a wrong result when a
> comma is missing in the schema definition
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-3414
> URL: https://issues.apache.org/jira/browse/PIG-3414
> Project: Pig
> Issue Type: Bug
> Components: parser
> Reporter: Cheolsoo Park
> Assignee: Cheolsoo Park
> Fix For: 0.12
>
> Attachments: PIG-3414.patch
>
>
> QueryParserDriver provides a convenient method to parse from string to
> LogicalSchema. But if a comma is missing between two fields in the schema
> definition, it silently returns a wrong result. For example,
> {code}
> a:int b:long
> {code}
> This string will be parsed up to "a:int", and "b:long" will be silently
> discarded. This should rather fail with a parser exception.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
