> On Oct. 13, 2013, 11:40 a.m., Julien Le Dem wrote: > > trunk/src/org/apache/pig/impl/util/Utils.java, lines 357-359 > > <https://reviews.apache.org/r/14552/diff/5/?file=364056#file364056line357> > > > > now it should be: > > } else if > > (TEMPFILE_STORAGE.TFILE.lowerName().equals(tmpFileCompressionStorage)) { > > return TEMPFILE_STORAGE.TFILE; > > } else { > > throw new ...Exception("unsupported format " + > > tmpFileCompressionStorage + ". Should be one of " + > > Arrays.toString(TEMPFILE_STORAGE.values())); > > }
Thanks for catching that. I incorporated this change. - Aniket ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14552/#review26963 ----------------------------------------------------------- On Oct. 12, 2013, 12:44 a.m., Aniket Mokashi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14552/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2013, 12:44 a.m.) > > > Review request for pig, Cheolsoo Park, Dmitriy Ryaboy, Julien Le Dem, and > Rohini Palaniswamy. > > > Bugs: PIG-3480 > https://issues.apache.org/jira/browse/PIG-3480 > > > Repository: pig > > > Description > ------- > > - Added a new parameter to make SequenceFileInterStorage optional. > - Added tests > - Refactored apis > > > Diffs > ----- > > trunk/conf/pig.properties 1530468 > trunk/src/org/apache/pig/PigConfiguration.java 1530468 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > 1530468 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/partitioners/WeightedRangePartitioner.java > 1530468 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartitionRearrange.java > 1530468 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/util/MapRedUtil.java > 1530468 > trunk/src/org/apache/pig/impl/io/InterStorage.java 1530468 > trunk/src/org/apache/pig/impl/io/SequenceFileInterStorage.java PRE-CREATION > trunk/src/org/apache/pig/impl/io/TFileStorage.java 1530468 > trunk/src/org/apache/pig/impl/util/Utils.java 1530468 > trunk/test/org/apache/pig/test/TestTmpFileCompression.java 1530468 > > Diff: https://reviews.apache.org/r/14552/diff/ > > > Testing > ------- > > > Thanks, > > Aniket Mokashi > >
