----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15524/#review28982 -----------------------------------------------------------
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java <https://reviews.apache.org/r/15524/#comment56038> Seems this is an optimization, shall we retain it? src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java <https://reviews.apache.org/r/15524/#comment56039> See previous comment src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java <https://reviews.apache.org/r/15524/#comment56040> See previous comment Another place to get rid of STATUS_NULL is POProject:313. Also in PORelationToExprProject (the actual code is in POProject.consumeInputBag), we shall make sure we ignore STATUS_NULL. - Daniel Dai On Nov. 14, 2013, 6:31 p.m., Mark Wagner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15524/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2013, 6:31 p.m.) > > > Review request for pig, Cheolsoo Park, Daniel Dai, and Rohini Palaniswamy. > > > Bugs: PIG-3568 > https://issues.apache.org/jira/browse/PIG-3568 > > > Repository: pig-git > > > Description > ------- > > This patch defines STATUS_NULL to mean that no result was produced and > changes all conflicts to conform with this interpretation. > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/POStatus.java > 6b7fa97 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java > 083702b > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/EqualToExpr.java > dfe43b4 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GTOrEqualToExpr.java > 64e180a > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/GreaterThanExpr.java > 77c2dfa > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LTOrEqualToExpr.java > 2d7c888 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/LessThanExpr.java > 15ad635 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/NotEqualToExpr.java > 076bc98 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POAnd.java > b9761c4 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POOr.java > e80a37d > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java > c33e3ad > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/PODistinct.java > bb93273 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFilter.java > d6f4a4f > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POLocalRearrange.java > bbf11c4 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPartialAgg.java > ffa211f > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPreCombinerLocalRearrange.java > 49c74bc > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POSort.java > 3f4f914 > test/org/apache/pig/test/TestEqualTo.java d827caa > test/org/apache/pig/test/TestGTOrEqual.java bb23eb4 > test/org/apache/pig/test/TestGreaterThan.java 6422e27 > test/org/apache/pig/test/TestLTOrEqual.java f9310d8 > test/org/apache/pig/test/TestLessThan.java 49b044f > test/org/apache/pig/test/TestNotEqualTo.java cf1ffee > > Diff: https://reviews.apache.org/r/15524/diff/ > > > Testing > ------- > > 'ant test-commit' on this patch, and 'ant test' before merging PIG-3570. > There were a couple failures from 'ant test', but they're unrelated > > > Thanks, > > Mark Wagner > >
