-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16463/
-----------------------------------------------------------
(Updated Dec. 26, 2013, 6:11 a.m.)
Review request for pig, Alex Bain, Daniel Dai, Mark Wagner, and Rohini
Palaniswamy.
Changes
-------
Edited description.
Bugs: PIG-3636
https://issues.apache.org/jira/browse/PIG-3636
Repository: pig-git
Description
-------
The patch implements accumulator optimization in Tez. The changes include-
* Create AccumulatorOptimizer in Tez.
* Create AccumulatorOptimizerUtil class and factor out common functions in MR
and Tez.
* Implement accumulator logic in POShuffleTezLoad.
* Update TestAccumulator to make it run in Tez mode.
Diffs
-----
src/org/apache/pig/PigConfiguration.java 0a26e8c
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/AccumulatorOptimizer.java
7f9e15a
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/MapReduceLauncher.java
9eed25c
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POPackage.java
6e04513
src/org/apache/pig/backend/hadoop/executionengine/tez/AccumulatorOptimizer.java
e69de29
src/org/apache/pig/backend/hadoop/executionengine/tez/POShuffleTezLoad.java
722b9f6
src/org/apache/pig/backend/hadoop/executionengine/tez/POUnionTezLoad.java
742a33a
src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java
d42ce89
src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java
c6af682
src/org/apache/pig/backend/hadoop/executionengine/tez/TezPlanContainer.java
e33a7c6
src/org/apache/pig/backend/hadoop/executionengine/util/AccumulatorOptimizerUtil.java
e69de29
test/org/apache/pig/test/TestAccumulator.java b979649
test/org/apache/pig/test/TestCombiner.java a227d18
test/tez-tests fcb573e
Diff: https://reviews.apache.org/r/16463/diff/
Testing (updated)
-------
* TestAccumulator passes in Tez mode.
* All unit tests pass.
* All e2e tests pass.
Note that 3 test cases in TestAccumulator are annotated as @Ignore because
SecondaryKeyOptimizer in Tez is not implement yet. The test cases expect
accumulator optimizer is applied when order-by and distinct are present in a
nested foreash because sort operator is removed by SecondaryKeyOptimizer. Added
TODO comments accordingly.
Thanks,
Cheolsoo Park
