----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18505/#review35548 -----------------------------------------------------------
src/org/apache/pig/impl/util/Utils.java <https://reviews.apache.org/r/18505/#comment66148> Just to know, is it the _SUCCESS files that you are trying to filter out? If so can the method be renamed to getSuccessMarkerPathFilter? Also can we add the method to org.apache.pig.test.Util in test package instead of this class? test/org/apache/pig/test/TestAccumulator.java <https://reviews.apache.org/r/18505/#comment66146> Why don't we set this in MiniCluster m_conf itself. Once we fix the original issue, then it will just be one place that needs to be fixed. test/org/apache/pig/test/data/GoldenFiles/TEZC11.gld <https://reviews.apache.org/r/18505/#comment66149> Combiner has gone missing. We need to fix this instead of changing golden file. Can you leave this file as is? test/org/apache/pig/test/data/GoldenFiles/TEZC7.gld <https://reviews.apache.org/r/18505/#comment66150> I think this one should be left as is till PIG-3757 is fully done. test/org/apache/pig/test/data/GoldenFiles/TEZC8.gld <https://reviews.apache.org/r/18505/#comment66153> This one also be left as is till PIG-3757 is fully done. The filter should not be there. test/org/apache/pig/test/data/GoldenFiles/TEZC9.gld <https://reviews.apache.org/r/18505/#comment66152> This one also be left as is till PIG-3757 is fully done. - Rohini Palaniswamy On Feb. 26, 2014, 2:13 a.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18505/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 2:13 a.m.) > > > Review request for pig, Daniel Dai and Rohini Palaniswamy. > > > Bugs: PIG-3780 > https://issues.apache.org/jira/browse/PIG-3780 > > > Repository: pig-git > > > Description > ------- > > Fixing unit tests in tez branch. Please see the details in the jira- > https://issues.apache.org/jira/browse/PIG-3780 > > > Diffs > ----- > > src/org/apache/pig/impl/util/Utils.java b38161f > test/org/apache/pig/test/TestAccumulator.java 428bc0e > test/org/apache/pig/test/TestCombiner.java a597543 > test/org/apache/pig/test/TestCustomPartitioner.java 6659518 > test/org/apache/pig/test/TestSkewedJoin.java 54fb4f6 > test/org/apache/pig/test/TestSplitStore.java 68e2b39 > test/org/apache/pig/test/data/GoldenFiles/TEZC1.gld 43ec93b > test/org/apache/pig/test/data/GoldenFiles/TEZC11.gld 5159d4c > test/org/apache/pig/test/data/GoldenFiles/TEZC12.gld 4835f87 > test/org/apache/pig/test/data/GoldenFiles/TEZC14.gld aa862a5 > test/org/apache/pig/test/data/GoldenFiles/TEZC15.gld 121d5c5 > test/org/apache/pig/test/data/GoldenFiles/TEZC16.gld 85ea020 > test/org/apache/pig/test/data/GoldenFiles/TEZC17.gld 45fff59 > test/org/apache/pig/test/data/GoldenFiles/TEZC2.gld 0b43b01 > test/org/apache/pig/test/data/GoldenFiles/TEZC3.gld fc3b874 > test/org/apache/pig/test/data/GoldenFiles/TEZC4.gld 884f62d > test/org/apache/pig/test/data/GoldenFiles/TEZC5.gld 73cc8fe > test/org/apache/pig/test/data/GoldenFiles/TEZC6.gld e48b754 > test/org/apache/pig/test/data/GoldenFiles/TEZC7.gld 21d7053 > test/org/apache/pig/test/data/GoldenFiles/TEZC8.gld 86c09c2 > test/org/apache/pig/test/data/GoldenFiles/TEZC9.gld 2c146cd > test/org/apache/pig/tez/TestTezCompiler.java a3f3bab > > Diff: https://reviews.apache.org/r/18505/diff/ > > > Testing > ------- > > > Thanks, > > Cheolsoo Park > >
