[
https://issues.apache.org/jira/browse/PIG-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940895#comment-13940895
]
Rohini Palaniswamy commented on PIG-3789:
-----------------------------------------
Patch looks good. But a thought. If we change all Tuple implementations'
readFields() method to do mFields = new ArrayList<Object>(); instead of
mFields.clear() if mFields.size > 0 (to not reinitialize array twice in case of
MR), then we can do newTupleNoCopy instead of newTuple. This will avoid a array
copy and be more efficient.
> tuple in POStream binaryInputQueue keep changing
> ------------------------------------------------
>
> Key: PIG-3789
> URL: https://issues.apache.org/jira/browse/PIG-3789
> Project: Pig
> Issue Type: Sub-task
> Components: tez
> Affects Versions: tez-branch
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: tez-branch
>
> Attachments: PIG-3789-1.patch, PIG-3789-2.patch
>
>
> Similar to the comments in POSimpleTezLoad:
> {code}
> /**
> * Previously, we reused the same Result object for all results, but we
> found
> * certain operators (e.g. POStream) save references to the Result object
> and
> * expect it to be constant.
> */
> {code}
> Tuples put into binaryInputQueue get changed when it is actually processed.
> Not exactly sure why, but make a copy of the tuple solves the issue.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
