[ 
https://issues.apache.org/jira/browse/PIG-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945777#comment-13945777
 ] 

Rohini Palaniswamy commented on PIG-3829:
-----------------------------------------

Why use Singleton classes instead of just instantiating constructor directly? 
i.e new TezStatusReporter(processorContext) and new 
PigTezLogger(aggregateWarning,  tezStatusReporter). It is not exactly Singleton 
as we are calling set methods after we do getInstance(). It may work ok with 
cluster mode as there will be only one task running in the jvm anytime, but in 
local mode this will have issues as all threadlocal variables of 
PhysicalOperator.reporter will have same PigTezLogger which will point to the 
last task instantiated.

> Make custom counter work
> ------------------------
>
>                 Key: PIG-3829
>                 URL: https://issues.apache.org/jira/browse/PIG-3829
>             Project: Pig
>          Issue Type: Sub-task
>          Components: tez
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: tez-branch
>
>         Attachments: PIG-3829-1.patch
>
>
> Make custom Pig counters defined in PigWarning/PigCounters work. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to