[ 
https://issues.apache.org/jira/browse/PIG-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957909#comment-13957909
 ] 

Cheolsoo Park commented on PIG-3858:
------------------------------------

[~lbendig], thank you for catching this! This is my fault (PIG-3679).

Your patch looks fine, but I have a suggestion. Why don't we just check whether 
pigLogger is null or not in POUserFunc? In fact, this is the 2nd time that we 
ran into this problem. (Pig-on-Tez also had run into this issue before we 
implemented customer counter support.) Assuming that counters are not 
meaningful in fetch mode, it seems better to make pigLogger optional. What do 
you think?

> PigLogger/PigStatusReporter is not set for fetch tasks
> ------------------------------------------------------
>
>                 Key: PIG-3858
>                 URL: https://issues.apache.org/jira/browse/PIG-3858
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Lorand Bendig
>            Assignee: Lorand Bendig
>         Attachments: PIG-3858.patch
>
>
> PigLogger initialization is missing which leads to NPE if counters are 
> accessed during a fetch tasks. Some queries to reproduce this issue:
> 1.
> {code}
> set opt.fetch true;
> A = load ...
> B = foreach A generate TOBAG(TOTUPLE(null));
> dump B;
> {code}
> -> NPE when PigWarning.SKIP_UDF_CALL_FOR_NULL is incremented
> 2.
> {code}
> set opt.fetch true;
> set pig.udf.profile true;
> A = load ...
> B = foreach A generate [any UDF]
> {code}
> -> NPE when POUserFunc.INVOCATION_COUNTER is incremented



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to