[ 
https://issues.apache.org/jira/browse/PIG-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13985005#comment-13985005
 ] 

Julien Le Dem commented on PIG-3913:
------------------------------------

This looks good to me.
Please add javadoc for deprecated methods with information about the new way of 
doing the same thing.
+1

> Pig should use job's jobClient wherever possible (fixes local mode counters)
> ----------------------------------------------------------------------------
>
>                 Key: PIG-3913
>                 URL: https://issues.apache.org/jira/browse/PIG-3913
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.13.0
>            Reporter: Aniket Mokashi
>            Assignee: Aniket Mokashi
>             Fix For: 0.13.0
>
>         Attachments: PIG-3913-1.patch
>
>
> MapreduceLauncher initializes a statsJobClient to poll counter information of 
> jobs. This works fine in mapreduce mode but it reports incorrect information 
> in local (auto-local) mode. Pig code should try to use 
> org.apache.hadoop.mapred.jobcontrol.Job's getJobClient api to get handle to 
> jobClient wherever possible. statsJobClient (and wherever its references are 
> passed) should be deprecated.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to