----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23673/#review48200 -----------------------------------------------------------
Ship it! Ship It! - Daniel Dai On July 18, 2014, 10 p.m., Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23673/ > ----------------------------------------------------------- > > (Updated July 18, 2014, 10 p.m.) > > > Review request for pig, Daniel Dai and Rohini Palaniswamy. > > > Bugs: PIG-4060 > https://issues.apache.org/jira/browse/PIG-4060 > > > Repository: pig-git > > > Description > ------- > > The changes include: > 1) Change TezJob to implement Runnable instead of extending ControlledJob. > 2) Change TezLauncher to submit TezJob via ScheduledExecutorService instead > of JobControl. > 3) Remove TezJobNotifier and TezJobControl since they're no longer used. > 4) Rename TezJobControlCompiler to TezJobCompiler. > > Operators that consist of more than 1 TezJobs still work. Basically, > TezPlanContainer holds multiple TezPlans and compiles them one by one in > TezLauncher. So eliminating JobControl has no impact on them. I confirmed > MergeJoin still works. > > > Diffs > ----- > > src/org/apache/pig/backend/hadoop/executionengine/Launcher.java e2e681c > src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > 77ebbdf > src/org/apache/pig/backend/hadoop/executionengine/tez/TezJob.java 80df093 > src/org/apache/pig/backend/hadoop/executionengine/tez/TezJobCompiler.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/tez/TezJobControl.java > eef4862 > > src/org/apache/pig/backend/hadoop/executionengine/tez/TezJobControlCompiler.java > 9a6bc1f > src/org/apache/pig/backend/hadoop/executionengine/tez/TezJobNotifier.java > 5766371 > src/org/apache/pig/backend/hadoop/executionengine/tez/TezLauncher.java > 7c0a109 > > src/org/apache/pig/backend/hadoop/executionengine/tez/TezSessionManager.java > c73d131 > src/org/apache/pig/tools/pigstats/tez/TezStats.java a8158d0 > test/org/apache/pig/tez/TestTezJobControlCompiler.java 2149d50 > > Diff: https://reviews.apache.org/r/23673/diff/ > > > Testing > ------- > > Verified that MergeJoin e2e tests pass. > > > Thanks, > > Cheolsoo Park > >
