[ 
https://issues.apache.org/jira/browse/PIG-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115802#comment-14115802
 ] 

Cheolsoo Park commented on PIG-4144:
------------------------------------

+1.

Two minor comments. Can you fix these when committing the patch?

# {{"Using default local mode"}} is not printed when {{EXEC_CLUSTER}} is "local"
{code}
+        ExecType execType = ExecType.LOCAL;
+        if (System.getProperties().containsKey(EXEC_CLUSTER)) {
+          if 
(System.getProperties().getProperty(EXEC_CLUSTER).equalsIgnoreCase("mr")) {
+            LOG.info("Using mr cluster mode");
+            execType = ExecType.MAPREDUCE;
+          } else if 
(System.getProperties().getProperty(EXEC_CLUSTER).equalsIgnoreCase("tez")) {
+            LOG.info("Using tez cluster mode");
+            execType = ExecTypeProvider.fromString("tez");
+          } else if 
(System.getProperties().getProperty(EXEC_CLUSTER).equalsIgnoreCase("tez_local"))
 {
+            LOG.info("Using tez local mode");
+            execType = ExecTypeProvider.fromString("tez_local");
+          }
+        } else {
+          LOG.info("Using default local mode");
+        }
{code}
# Can you update Pig doc about {{pigunit.exectype.cluster}}? This is no longer 
true w/ your changes, right?
{quote}
        It is enabled when the Java system property pigunit.exectype.cluster is 
set to any value: e.g. -Dpigunit.exectype.cluster=true or 
System.getProperties().setProperty("pigunit.exectype.cluster", "true"). The 
cluster you select must be specified in the CLASSPATH (similar to the 
HADOOP_CONF_DIR variable).
{quote}

> Make pigunit.PigTest work in tez mode
> -------------------------------------
>
>                 Key: PIG-4144
>                 URL: https://issues.apache.org/jira/browse/PIG-4144
>             Project: Pig
>          Issue Type: Sub-task
>          Components: tez
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.14.0
>
>         Attachments: PIG-4144-1.patch, PIG-4144-2.patch
>
>
> pigunit.PigTest does not work in both tez_local and tez mode. Need to make it 
> work.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to