----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29645/#review67688 -----------------------------------------------------------
trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POReservoirSample.java <https://reviews.apache.org/r/29645/#comment111767> This can be moved inside the new if block trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java <https://reviews.apache.org/r/29645/#comment111769> Why do we need this condition. i.e, In what case is the store operator predecessor of the tezOp? trunk/src/org/apache/pig/builtin/mock/Storage.java <https://reviews.apache.org/r/29645/#comment111837> why should we do this? Having to create a copy in a StoreFunc does not look good. trunk/test/org/apache/pig/test/TestCubeOperator.java <https://reviews.apache.org/r/29645/#comment111838> Unintended change which reverts the recent rollup patch. Need to rollback. testRollupHIIAfterCogroup - Naming is weird though. Need to go back and review the rollup patch. trunk/test/org/apache/pig/test/TestCubeOperator.java <https://reviews.apache.org/r/29645/#comment112649> Can you add PIG-3993 to the message? Easy to search later. Need to add to some illustrate local mode tests in TestGrunt as well. trunk/test/org/apache/pig/test/TestJoin.java <https://reviews.apache.org/r/29645/#comment112652> TestJoinLocal seems to be missing in the patch. I think we can keep TestJoin as is for cluster tests without having to create a abstract TestJoinBase and just create a TestJoinLocal which extends TestJoin and uses Local mode as all tests are same. Will help keep changes simple and have just two classes instead of three. trunk/test/org/apache/pig/test/TestPigStatsMR.java <https://reviews.apache.org/r/29645/#comment112656> Make method more generic assertNumberOfJobs(ExecJob job, int expectedNumJobs) { .... assertEquals(expectedNumJobs, jobGraph.getJobList().size()); } trunk/test/org/apache/pig/test/TestPigStatsMR.java <https://reviews.apache.org/r/29645/#comment112653> private trunk/test/org/apache/pig/test/TestPigStatsMR.java <https://reviews.apache.org/r/29645/#comment112654> private trunk/test/tez-local-tests <https://reviews.apache.org/r/29645/#comment112648> Can we add tests in the order they will be executed? Find it easy to comment the already run ones and re-run if I find a failure in the middle. - Rohini Palaniswamy On Jan. 6, 2015, 11:49 p.m., Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29645/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 11:49 p.m.) > > > Review request for pig and Rohini Palaniswamy. > > > Bugs: PIG-4366 > https://issues.apache.org/jira/browse/PIG-4366 > > > Repository: pig > > > Description > ------- > > See PIG-4366 > > > Diffs > ----- > > > trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POReservoirSample.java > 1649730 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java > 1649730 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/MultiQueryOptimizerTez.java > 1649730 > trunk/src/org/apache/pig/builtin/mock/Storage.java 1649730 > trunk/src/org/apache/pig/tools/pigstats/tez/TezScriptState.java 1649730 > trunk/test/excluded-tests-20 1649730 > trunk/test/org/apache/pig/test/TestCubeOperator.java 1649730 > trunk/test/org/apache/pig/test/TestJoin.java 1649730 > trunk/test/org/apache/pig/test/TestJoinBase.java PRE-CREATION > trunk/test/org/apache/pig/test/TestMultiQuery.java 1649730 > trunk/test/org/apache/pig/test/TestNewPlanColumnPrune.java 1649730 > trunk/test/org/apache/pig/test/TestPigServer.java 1649730 > trunk/test/org/apache/pig/test/TestPigServerLocal.java PRE-CREATION > trunk/test/org/apache/pig/test/TestPigStats.java 1649730 > trunk/test/org/apache/pig/test/TestPigStatsMR.java PRE-CREATION > trunk/test/org/apache/pig/test/TestPruneColumn.java 1649730 > trunk/test/org/apache/pig/test/TestRank3.java 1649730 > trunk/test/org/apache/pig/test/TestScalarAliases.java 1649730 > trunk/test/org/apache/pig/test/TestScalarAliasesLocal.java PRE-CREATION > trunk/test/org/apache/pig/test/Util.java 1649730 > trunk/test/org/apache/pig/tez/TestPigStatsTez.java PRE-CREATION > trunk/test/tez-local-tests 1649730 > > Diff: https://reviews.apache.org/r/29645/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Dai > >
