[ 
https://issues.apache.org/jira/browse/PIG-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319236#comment-14319236
 ] 

Rohini Palaniswamy commented on PIG-4414:
-----------------------------------------

[~zjffdu],
    Why should TezConfiguration.TEZ_SITE_XML be made private? 

bq. If pig folks feel OK, the following piece of code also do the same thing, 
and is encouraged to do like this - jc.addResource(new TezConfiguration());
  As far as I see Configuration.addResource() only takes String, Path, URL or 
InputStream. How is the above going to work?

> TezConfiguration.TEZ_SITE_XML is made private in tez-0.7
> --------------------------------------------------------
>
>                 Key: PIG-4414
>                 URL: https://issues.apache.org/jira/browse/PIG-4414
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Daniel Dai
>             Fix For: 0.15.0
>
>
> TezConfiguration.TEZ_SITE_XML is made private in tez-0.7, and it is supposed 
> to be private. 
> But pig use this field
> {code}
>    @Override
>     public JobConf getExecConf(Properties properties) throws ExecException {
>         JobConf jc = super.getExecConf(properties);
>         jc.addResource(TezConfiguration.TEZ_SITE_XML);
>         return jc;
>     }
> {code}
> If pig folks feel OK, the following piece of code also do the same thing, and 
> is encouraged to do like this 
> {code}
> jc.addResource(new TezConfiguration());
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to