[
https://issues.apache.org/jira/browse/PIG-4490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohini Palaniswamy updated PIG-4490:
------------------------------------
Attachment: PIG-4490-1.patch
Thanks [[email protected]]. The new tests are good.
Did some additional changes on [[email protected]]'s patch when I saw the
duplication of code with asserts. So
- Extracted out the repeated asserts in the multiple min and max tests
into a method.
- Also added some javadoc to make the new Util method more clear. It is a
good one could really be useful when writing future tests.
[~daijy], can you review the changes.
> MIN/MAX builtin UDFs return wrong results when accumulating for strings
> -----------------------------------------------------------------------
>
> Key: PIG-4490
> URL: https://issues.apache.org/jira/browse/PIG-4490
> Project: Pig
> Issue Type: Bug
> Components: internal-udfs
> Affects Versions: 0.12.0, 0.13.0, 0.14.0
> Reporter: xplenty
> Assignee: xplenty
> Fix For: 0.15.0
>
> Attachments: PIG-4490-1.patch, fix-min-max-test.patch,
> fix-min-max.patch
>
>
> When using MIN/MAX UDFs with strings in a job that uses the accumulator
> interface the results are wrong - The UDF won't return the correct MIN/MAX
> value.
> this is caused by a reverse 'GreaterThan/SmallerThan" (<>) sign in the
> accumulate() function of both StringMin/StringMax UDFs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
