----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34537/#review87744 -----------------------------------------------------------
trunk/test/org/apache/pig/test/TestAccumulator.java <https://reviews.apache.org/r/34537/#comment140155> Instead of this, can you change to use Util.checkQueryOutputsAfterSort(iter, expectedResults); Refer TestBinaryExpressionOps.testArithmeticOperators - Rohini Palaniswamy On May 21, 2015, 10:38 a.m., Eyal Allweil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34537/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 10:38 a.m.) > > > Review request for pig. > > > Bugs: PIG-4365 > https://issues.apache.org/jira/browse/PIG-4365 > > > Repository: pig > > > Description > ------- > > I think the implementation of Accumulator is pretty straightforward - I > extented AccumulatorEvalFunc and so that very few changes were needed. > > > Diffs > ----- > > trunk/src/org/apache/pig/builtin/TOP.java 1680807 > trunk/test/org/apache/pig/builtin/TestTOP.java 1680807 > trunk/test/org/apache/pig/test/TestAccumulator.java 1680807 > > Diff: https://reviews.apache.org/r/34537/diff/ > > > Testing > ------- > > > Thanks, > > Eyal Allweil > >