[
https://issues.apache.org/jira/browse/PIG-4607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14603803#comment-14603803
]
Mohit Sabharwal commented on PIG-4607:
--------------------------------------
Thanks for the explanation, [~kexianda]! And thanks for fixing the
verifyExpected bug!
Code LGTM. I have a minor comment to preserve consistency since we changing
non-spark related code:
If you see other Pig testcases that use {{checkQueryOutputsAfterSort}}, these
use the following pattern:
{code}
List<Tuple> expectedResults = Util.getTuplesFromConstantTupleStrings(
new String[] {
"((1,'a'),(1,'b'))",
"((2,'aa'),(2,'bb'))"
});
Util.checkQueryOutputsAfterSort(it, expectedResults);
{code}
For consistency, we should use {{Util.getTuplesFromConstantTupleStrings}}
instead of creating a Tuple[] and then converting it to a List.
> Enable "TestRank1","TestRank3" unit tests in spark mode
> -------------------------------------------------------
>
> Key: PIG-4607
> URL: https://issues.apache.org/jira/browse/PIG-4607
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: kexianda
> Fix For: spark-branch
>
> Attachments: PIG-4607.patch
>
>
> In https://builds.apache.org/job/Pig-spark/216/#showFailuresLink, unit tests
> about TestRank1, TestRank3:
> org.apache.pig.test.TestRank1.testRank02RowNumber
> org.apache.pig.test.TestRank1.testRank01RowNumber
> org.apache.pig.test.TestRank3.testRankWithSplitInMap
> org.apache.pig.test.TestRank3.testRankWithSplitInReduce
> org.apache.pig.test.TestRank3.testRankCascade
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
