[
https://issues.apache.org/jira/browse/PIG-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641986#comment-14641986
]
kexianda commented on PIG-4594:
-------------------------------
Hi [~mohitsabharwal], In MR implementation, when connect a physicalOperator to
others, a new copy is cloned.
For instance, If we want to connect x to y and z. In MR implementation, we
clone two copies x1 and x2. x1 will be connected to y, x2 will be connected to
z. That is why don't we see "This operator does not support multiple outputs"
exception with Tez or MR
{code}
for (PhysicalOperator op : rootsCopy) {
//...
clone = pl.clone();
//..
oper = clone.getLeaves().get(0);
succ.mapPlan.add(oper);
succ.mapPlan.connect(oper, opSucc);
//..
}
{code}
In MutliQueryOptimizerSpark.java, [~kellyzly] did not make a copy of the
physicalOperator, just force connect it to other operators. I don't why, but it
seems work. Hmm... we can do more testing in future.
LGTM. + 1 (non-binding). We can address any changes in future patches
> Enable "TestMultiQuery" in spark mode
> -------------------------------------
>
> Key: PIG-4594
> URL: https://issues.apache.org/jira/browse/PIG-4594
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
> Attachments: PIG-4594.patch, PIG-4594_1.patch, PIG-4594_2.patch
>
>
> in https://builds.apache.org/job/Pig-spark/211/#showFailuresLink,it shows
> that
> following unit test failures fail:
> org.apache.pig.test.TestMultiQuery.testMultiQueryJiraPig1068
> org.apache.pig.test.TestMultiQuery.testMultiQueryJiraPig1157
> org.apache.pig.test.TestMultiQuery.testMultiQueryJiraPig1252
> org.apache.pig.test.TestMultiQuery.testMultiQueryJiraPig1438
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
