[
https://issues.apache.org/jira/browse/PIG-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015041#comment-15015041
]
liyunzhang_intel commented on PIG-4741:
---------------------------------------
[~sriksun] and [~xuefuz]:
I read the code changes in PIG-4667 and find a problem in variable
{{SPARK_DIST_CLASSPATH}}.
{code}
SPARK_DIST_CLASSPATH=${SPARK_DIST_CLASSPATH}:\${PWD}/`basename $f`
{code}
the "\" is unnecessary because we need not escape {{PWD}}. I think following is
also right and it is more understandable.
{code}
SPARK_DIST_CLASSPATH=${SPARK_DIST_CLASSPATH}:$f
{code}
If my understandanding is wrong, please tell me.
> the value of $SPARK_DIST_CLASSPATH in pig file is invalid
> ---------------------------------------------------------
>
> Key: PIG-4741
> URL: https://issues.apache.org/jira/browse/PIG-4741
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
> Attachments: PIG-4741.patch
>
>
> the value of
> [$SPARK_DIST_CLASSPATH|https://github.com/apache/pig/blob/spark/bin/pig#L380]
> in bin/pig is invalid
> {code}
> SPARK_DIST_CLASSPATH=${SPARK_DIST_CLASSPATH}:\${PWD}/`basename $f`
> {code}
> there is no need to escape the {{PWD}}. If we add "\", the value of
> SPARK_DIST_CLASSPATH will like:
> {code}
>
> ${PWD}/akka-actor_2.10-2.3.4-spark.jar:${PWD}/akka-remote_2.10-2.3.4-spark.jar
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
