----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45667/#review134255 -----------------------------------------------------------
Review comments for all non-spark classes. bin/pig (line 365) <https://reviews.apache.org/r/45667/#comment198955> This is not a good idea. If I remember correctly, spark-assembly.jar is 128MB+. If you are copying all the individual jars that it is made up of to distcache for every job, it will suffer bad performance as copy to hdfs and localization by NM will be very costly. Like Tez you can have users copy the assembly jar to hdfs and specify the hdfs location. This will ensure there is only one copy in hdfs and localization is done only once per node by node manager. bin/pig (line 426) <https://reviews.apache.org/r/45667/#comment198956> Why is this extra variable needed? This will be a problem if users are programatically calling PigServer instead of using bin/pig build.xml (line 366) <https://reviews.apache.org/r/45667/#comment198949> Can you confirm that with all the spark changes running with hadoop 1.x (ant test -Dhadoopversion=20) is good? build.xml (lines 401 - 415) <https://reviews.apache.org/r/45667/#comment198950> Please remove this. This target is supposed to contain the minimum jars required for just Pig without any hadooop, tez or spark dependencies. build.xml (line 771) <https://reviews.apache.org/r/45667/#comment198951> Directory path will be build/ivy/lib/spark/Pig. You can just do build/ivy/lib/spark. build.xml (line 1052) <https://reviews.apache.org/r/45667/#comment198952> spark mode ivy.xml (line 451) <https://reviews.apache.org/r/45667/#comment198954> What does 2.10 in spark-core_2.10 and spark-yarn_2.10 signify? ivy/libraries.properties (line 80) <https://reviews.apache.org/r/45667/#comment198953> Can we move to 1.6.1? shims/test/hadoop20/org/apache/pig/test/SparkMiniCluster.java (line 68) <https://reviews.apache.org/r/45667/#comment198958> You will have to implement getLauncher method. Else will end up with infinite loop. Refer PIG-4530 shims/test/hadoop23/org/apache/pig/test/SparkMiniCluster.java (line 38) <https://reviews.apache.org/r/45667/#comment198961> You should move common code between TezMiniCluster and this into a YarnMiniCluster class to avoid duplication of code. TezMiniCluster and SparkMiniCluster can then extend that class and override specific methods. shims/test/hadoop23/org/apache/pig/test/SparkMiniCluster.java (line 52) <https://reviews.apache.org/r/45667/#comment198959> Formatting nitpick. New line before the constructor. src/META-INF/services/org.apache.pig.ExecType (lines 16 - 17) <https://reviews.apache.org/r/45667/#comment198962> Need to be uncommented back. src/docs/src/documentation/content/xdocs/start.xml (line 99) <https://reviews.apache.org/r/45667/#comment198963> This file and content needs rebasing with trunk to include latest changes. Spark Local Mode should be after Tez Local Mode and Spark Mode after Tez Mode so that local modes are together as it is in the current trunk version. src/docs/src/documentation/content/xdocs/start.xml (line 132) <https://reviews.apache.org/r/45667/#comment198964> six execution modes src/docs/src/documentation/content/xdocs/start.xml (line 143) <https://reviews.apache.org/r/45667/#comment198965> 1) Can you add a section for Spark Local Mode as well? In all other places of the documentation as well wherever there is tez_local. 2) Can we add a bulleted list for the different options of env::SPARK_MASTER for easy readability. src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java (line 123) <https://reviews.apache.org/r/45667/#comment198966> Formatting nitpick. Space between () and { src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java (line 153) <https://reviews.apache.org/r/45667/#comment198967> Can this additional method be avoided? What is the special case that this is required for? src/org/apache/pig/backend/hadoop/executionengine/spark/JobGraphBuilder.java (line 72) <https://reviews.apache.org/r/45667/#comment198968> Formatting nitpick. Break into multiple lines. src/org/apache/pig/backend/hadoop/executionengine/util/AccumulatorOptimizerUtil.java (line 294) <https://reviews.apache.org/r/45667/#comment199079> The utility class is for common code between mapreduce, tez and spark. Please move all Spark specific code to the spark AccumulatorOptimizer src/org/apache/pig/backend/hadoop/executionengine/util/SecondaryKeyOptimizerUtil.java (line 59) <https://reviews.apache.org/r/45667/#comment199080> It is not a good idea to use a static variable to keep state in this static class. Multi-threaded use of Pig will have issues if different modes are used. This utility class is for code common to mapreduce, tez and spark. Please move the spark specific code to spark's SecondaryKeyOptimizer. This is also necessary if we ever complete the mavenization and move tez and spark specific code to separate modules. src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java (line 313) <https://reviews.apache.org/r/45667/#comment199081> Just change the code to use UDFContext.getUDFContext().getJobConf() which should not be null instead of getClientSystemProps(). Not sure why it is using getClientSystemProps() in the first place. src/org/apache/pig/data/SelfSpillBag.java (line 32) <https://reviews.apache.org/r/45667/#comment199082> Why is bag even being serialized by Spark? src/org/apache/pig/impl/PigContext.java (line 924) <https://reviews.apache.org/r/45667/#comment199083> This can be reverted. PigContext need not be serialized to the backend. See PIG-4866 test/e2e/pig/conf/spark.conf (line 58) <https://reviews.apache.org/r/45667/#comment199031> Why local instead of mapreduce? test/org/apache/pig/newplan/logical/relational/TestLocationInPhysicalPlan.java (line 66) <https://reviews.apache.org/r/45667/#comment199032> Why does A[3,4] repeat? test/org/apache/pig/spark/TestIndexedKey.java (lines 2 - 5) <https://reviews.apache.org/r/45667/#comment199036> Keep license formatting same in all the files. Might cause issue with RAT report. test/org/apache/pig/test/TestBuiltin.java (line 3248) <https://reviews.apache.org/r/45667/#comment199039> Jira number does not seem to be the right one. test/org/apache/pig/test/TestBuiltin.java (line 3255) <https://reviews.apache.org/r/45667/#comment199040> This testcase is broken if you have 0-0 repeating twice. It is not UniqueID anymore. test/org/apache/pig/test/TestCollectedGroup.java (line 297) <https://reviews.apache.org/r/45667/#comment199041> Please use Assume.assumeTrue to skip tests for spark instead of if conditions. The test will also show up as Skipped instead of Passed. Assume.assumeTrue("Skip this test for Spark. See <jira>", !Util.isSparkExecType(cluster.getExecType())); test/org/apache/pig/test/TestCombiner.java (lines 189 - 191) <https://reviews.apache.org/r/45667/#comment199043> Can be removed with the change to checkCombinerUsed test/org/apache/pig/test/TestCombiner.java (lines 239 - 241) <https://reviews.apache.org/r/45667/#comment199044> Can be removed with the change to checkCombinerUsed test/org/apache/pig/test/TestCombiner.java (line 409) <https://reviews.apache.org/r/45667/#comment199046> Can we use the name "alias" instead of "variable" here? test/org/apache/pig/test/TestCombiner.java (line 416) <https://reviews.apache.org/r/45667/#comment199042> Util.isSparkExecType test/org/apache/pig/test/TestEvalPipeline.java (lines 431 - 436) <https://reviews.apache.org/r/45667/#comment199053> Can be extracted to a utility method as it is repeated multiple times. test/org/apache/pig/test/TestEvalPipeline2.java (line 770) <https://reviews.apache.org/r/45667/#comment199055> Can be simplified as Util.checkQueryOutputs(iter, expectedResults, Util.isSparkExecType()); by adding another Util method. Please replace in other tests as well where it has been changed to Util.checkQueryOutputsAfterSort instead of Util.checkQueryOutputs. Util.java public static void checkQueryOutputs(Iterator<Tuple> actualResults, Tuple[] expectedResults, boolean checkAfterSort) { if (checkAfterSort) { checkQueryOutputsAfterSort(actualResults, Arrays.asList(expectedResults)); } else { checkQueryOutputs(actualResults, Arrays.asList(expectedResults)); } } test/org/apache/pig/test/TestEvalPipelineLocal.java (lines 1117 - 1118) <https://reviews.apache.org/r/45667/#comment199056> Code should be taking care of this. test/org/apache/pig/test/TestFinish.java (line 48) <https://reviews.apache.org/r/45667/#comment199058> private static test/org/apache/pig/test/TestFinish.java (line 72) <https://reviews.apache.org/r/45667/#comment199057> This should not be done. The cluster object is not something a user UDF will have access to. test/org/apache/pig/test/TestFinish.java (line 144) <https://reviews.apache.org/r/45667/#comment199059> To be reverted test/org/apache/pig/test/TestFinish.java (line 163) <https://reviews.apache.org/r/45667/#comment199060> To be reverted test/org/apache/pig/test/TestGrunt.java (line 937) <https://reviews.apache.org/r/45667/#comment199061> Assert.assumeTrue test/org/apache/pig/test/TestLimitVariable.java (line 93) <https://reviews.apache.org/r/45667/#comment199062> Please revert the type change to int. This testcase is testing bytearray casting. test/org/apache/pig/test/TestLimitVariable.java (line 117) <https://reviews.apache.org/r/45667/#comment199063> Please revert the type change to int. This testcase is testing bytearray casting. test/org/apache/pig/test/TestMapSideCogroup.java (line 339) <https://reviews.apache.org/r/45667/#comment199066> Why is output ordering different with merge join? The assumption with merge join is that files are sorted and join is done based on that. So ordering should be same. test/org/apache/pig/test/TestMergeJoin.java (line 641) <https://reviews.apache.org/r/45667/#comment199064> Assume.assumeTrue test/org/apache/pig/test/TestMergeJoin.java (line 690) <https://reviews.apache.org/r/45667/#comment199065> Assume.assumeTrue test/org/apache/pig/test/TestMergeJoinOuter.java (line 173) <https://reviews.apache.org/r/45667/#comment199068> Assume.assumeTrue for all tests in this class test/org/apache/pig/test/TestMultiQuery.java (line 115) <https://reviews.apache.org/r/45667/#comment199070> Why are we using checkQueryOutputsAfterSortRecursive in many places when checkQueryOutputsAfterSort would do? It will unnecessarily increase the test execution time. Can they all be changed? Or am I missing something and checkQueryOutputsAfterSort cannot be used for some reason? test/org/apache/pig/test/TestPigRunner.java (lines 333 - 334) <https://reviews.apache.org/r/45667/#comment199074> 1 job for 1 POStore can impact performance. It is not exactly multi-query. Is there a jira to optimize this better and use 1 job? test/org/apache/pig/test/TestPigRunner.java (line 1155) <https://reviews.apache.org/r/45667/#comment199075> Is there a jira to fix the number of records? test/org/apache/pig/test/TestPigServerLocal.java (line 265) <https://reviews.apache.org/r/45667/#comment199076> Can you add _testParseBatchWithScripting as well? test/org/apache/pig/test/TestSecondarySort.java (line 364) <https://reviews.apache.org/r/45667/#comment199052> It is not right to check output after sorting here. This is an order by query. Output should already be in the expected order. test/org/apache/pig/test/TestSecondarySort.java (line 512) <https://reviews.apache.org/r/45667/#comment199051> Use Assume.assumeTrue test/org/apache/pig/test/TestSkewedJoin.java (line 290) <https://reviews.apache.org/r/45667/#comment199050> Use Assume.assumeTrue test/org/apache/pig/test/TestStoreBase.java (line 155) <https://reviews.apache.org/r/45667/#comment199047> Second store should not succeed. test/org/apache/pig/test/TestStoreBase.java (line 165) <https://reviews.apache.org/r/45667/#comment199049> Setup job file of second one should also be there. Same with setup task as well. They are supposed to happen before putNext of both the stores is called. - Rohini Palaniswamy On April 4, 2016, 5:19 a.m., Pallavi Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45667/ > ----------------------------------------------------------- > > (Updated April 4, 2016, 5:19 a.m.) > > > Review request for pig, Daniel Dai and Rohini Palaniswamy. > > > Bugs: PIG-4059 and PIG-4854 > https://issues.apache.org/jira/browse/PIG-4059 > https://issues.apache.org/jira/browse/PIG-4854 > > > Repository: pig-git > > > Description > ------- > > The patch contains all the work done in the spark branch, so far. > > > Diffs > ----- > > bin/pig 81f1426 > build.xml 8db1a80 > ivy.xml dd9878e > ivy/libraries.properties 55d9aed > shims/test/hadoop20/org/apache/pig/test/SparkMiniCluster.java PRE-CREATION > shims/test/hadoop23/org/apache/pig/test/SparkMiniCluster.java PRE-CREATION > src/META-INF/services/org.apache.pig.ExecType 5c034c8 > src/docs/src/documentation/content/xdocs/start.xml 36f9952 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/PhysicalOperator.java > 1ff1abd > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java > ecf780c > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/plans/PhysicalPlan.java > 2376d03 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POCollectedGroup.java > bcbfe2b > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POFRJoin.java > 894cda7 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POForEach.java > 21b75f1 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POGlobalRearrange.java > 52cfb73 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POMergeJoin.java > 6adfa91 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/relationalOperators/POSort.java > c3a82c3 > > src/org/apache/pig/backend/hadoop/executionengine/spark/JobGraphBuilder.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/JobMetricsListener.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/spark/KryoSerializer.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/MapReducePartitionerWrapper.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkExecType.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkExecutionEngine.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLauncher.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkLocalExecType.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/spark/SparkUtil.java > PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/spark/UDFJarsFinder.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/CollectedGroupConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/CounterConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/DistinctConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/FRJoinConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/FilterConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/ForEachConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/GlobalRearrangeConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/IndexedKey.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/IteratorTransform.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/LimitConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/LoadConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/LocalRearrangeConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/MergeCogroupConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/MergeJoinConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/OutputConsumerIterator.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/PackageConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/PigSecondaryKeyComparatorSpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/RDDConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/RankConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/ReduceByConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/SkewedJoinConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/SortConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/SplitConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/StoreConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/StreamConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/converter/UnionConverter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/operator/NativeSparkOperator.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/operator/POGlobalRearrangeSpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/operator/POReduceBySpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/AccumulatorOptimizer.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/CombinerOptimizer.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/MultiQueryOptimizerSpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/NoopFilterRemover.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/ParallelismSetter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/SecondaryKeyOptimizerSpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/DotSparkPrinter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkCompiler.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkCompilerException.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkOpPlanVisitor.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkOperPlan.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkOperator.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkPOPackageAnnotator.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/plan/SparkPrinter.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/spark/running/PigInputFormatSpark.java > PRE-CREATION > > src/org/apache/pig/backend/hadoop/executionengine/util/AccumulatorOptimizerUtil.java > c4b44ad > > src/org/apache/pig/backend/hadoop/executionengine/util/CombinerOptimizerUtil.java > 889c01b > > src/org/apache/pig/backend/hadoop/executionengine/util/SecondaryKeyOptimizerUtil.java > 0b59c9c > src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java e0581d9 > src/org/apache/pig/data/SelfSpillBag.java d17f0a8 > src/org/apache/pig/impl/PigContext.java d43949f > src/org/apache/pig/impl/plan/OperatorPlan.java 8b2e2e7 > src/org/apache/pig/tools/pigstats/PigStatsUtil.java 542cc2e > src/org/apache/pig/tools/pigstats/spark/SparkCounter.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkCounterGroup.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkCounters.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkJobStats.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkPigStats.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkPigStatusReporter.java > PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkScriptState.java PRE-CREATION > src/org/apache/pig/tools/pigstats/spark/SparkStatsUtil.java PRE-CREATION > test/e2e/pig/build.xml f7c38ba > test/e2e/pig/conf/spark.conf PRE-CREATION > test/e2e/pig/drivers/TestDriverPig.pm bf9c302 > test/e2e/pig/tests/streaming.conf 18f2fb2 > test/excluded-tests-spark PRE-CREATION > > test/org/apache/pig/newplan/logical/relational/TestLocationInPhysicalPlan.java > 94b34b3 > test/org/apache/pig/spark/TestIndexedKey.java PRE-CREATION > test/org/apache/pig/spark/TestSecondarySortSpark.java PRE-CREATION > test/org/apache/pig/test/MiniGenericCluster.java 9347269 > test/org/apache/pig/test/TestAssert.java 6d4b5c6 > test/org/apache/pig/test/TestBuiltin.java 44b4d09 > test/org/apache/pig/test/TestCase.java c9bb2fa > test/org/apache/pig/test/TestCollectedGroup.java a958d33 > test/org/apache/pig/test/TestCombiner.java df44293 > test/org/apache/pig/test/TestCubeOperator.java de96e6c > test/org/apache/pig/test/TestEvalPipeline.java 9efde13 > test/org/apache/pig/test/TestEvalPipeline2.java c8f51d7 > test/org/apache/pig/test/TestEvalPipelineLocal.java c12d595 > test/org/apache/pig/test/TestFinish.java f18c103 > test/org/apache/pig/test/TestForEachNestedPlanLocal.java b0aa3a8 > test/org/apache/pig/test/TestGrunt.java ef121a3 > test/org/apache/pig/test/TestHBaseStorage.java 8d2ad85 > test/org/apache/pig/test/TestLimitVariable.java 53b9dae > test/org/apache/pig/test/TestMapSideCogroup.java 2c78b4a > test/org/apache/pig/test/TestMergeJoin.java f1a9608 > test/org/apache/pig/test/TestMergeJoinOuter.java 81aee55 > test/org/apache/pig/test/TestMultiQuery.java 40684b4 > test/org/apache/pig/test/TestMultiQueryLocal.java b9ac035 > test/org/apache/pig/test/TestNativeMapReduce.java c4f6573 > test/org/apache/pig/test/TestNullConstant.java 3ea4509 > test/org/apache/pig/test/TestPigRunner.java fde8609 > test/org/apache/pig/test/TestPigServerLocal.java fbabd03 > test/org/apache/pig/test/TestProjectRange.java 2e3e7b8 > test/org/apache/pig/test/TestPruneColumn.java 3936332 > test/org/apache/pig/test/TestRank1.java 9e4ef62 > test/org/apache/pig/test/TestRank2.java fc802a9 > test/org/apache/pig/test/TestRank3.java 43af10d > test/org/apache/pig/test/TestSecondarySort.java 8991010 > test/org/apache/pig/test/TestSkewedJoin.java dba2241 > test/org/apache/pig/test/TestStoreBase.java eb3b253 > test/org/apache/pig/test/Util.java 8dae247 > test/spark-tests PRE-CREATION > > Diff: https://reviews.apache.org/r/45667/diff/ > > > Testing > ------- > > New UTs were added where required and ensure old UTs pass -> > https://builds.apache.org/job/Pig-spark/ > > > Thanks, > > Pallavi Rao > >
