[ 
https://issues.apache.org/jira/browse/PIG-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15561830#comment-15561830
 ] 

Nandor Kollar edited comment on PIG-4750 at 10/10/16 9:48 AM:
--------------------------------------------------------------

Attached a patch and two test cases. This patch changes the REPLACE_MULTI 
semantic:
- no chaining of replacement rule, all are applied now in one go, rule "a" -> 
"b" and "b" -> "c" on "a b" will result in "b c" and not "c c", like before
- keys in the replacement map are treated as plain string, and not regex: "|" 
-> "x" will replace all "|" to "x" in input

[~rohini] could you please have a look at my patch?


was (Author: nkollar):
Attached a patch and two test cases. This patch changes the REPLACE_MULTI 
semantic:
- no chaining of replacement rule, all are applied now in one go, rule "a" -> 
"b" and "b" -> "c" on "a b" will result in "b c" and not "c c", like before
- keys in the replacement map are treated as plain string, and not regex: "|" 
-> "x" will replace all "|" to "x" in input
[~rohini] could you please have a look at my patch?

> REPLACE_MULTI should compile Pattern once and reuse it
> ------------------------------------------------------
>
>                 Key: PIG-4750
>                 URL: https://issues.apache.org/jira/browse/PIG-4750
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Rohini Palaniswamy
>            Assignee: Nandor Kollar
>              Labels: newbie
>         Attachments: PIG-4750.patch
>
>
> Details in 
> https://issues.apache.org/jira/browse/PIG-4673?focusedCommentId=14876190&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14876190



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to