[
https://issues.apache.org/jira/browse/PIG-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715158#comment-15715158
]
Nandor Kollar commented on PIG-3891:
------------------------------------
Thanks [~rohini] for your comments, I made the required adjustments:
- Reverted CHANGES.txt
- Reverted the changes on ExecType and TezMiniCluster, but I think my patch
didn't change the visibility of the exec types, since those were declared
inside an interface.
- Changed the assert message.
- Rewrote the assert as you suggested, indeed, it looks better without the
branch. Test passes both on Tez and MR mode.
Attached new version: PIG-3891-5.patch. Could you please have a look at it?
> FileBasedOutputSizeReader does not calculate size of files in sub-directories
> -----------------------------------------------------------------------------
>
> Key: PIG-3891
> URL: https://issues.apache.org/jira/browse/PIG-3891
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.12.0
> Reporter: Rohini Palaniswamy
> Assignee: Nandor Kollar
> Attachments: PIG-3891-1.patch, PIG-3891-2.patch, PIG-3891-3.patch,
> PIG-3891-4.patch
>
>
> FileBasedOutputSizeReader only includes files in the top level output
> directory. So if files are stored under subdirectories (For eg:
> MultiStorage), it does not have the bytes written correctly.
> 0.11 shows the correct number of total bytes written and this is a
> regression. A quick look at the code shows that the
> JobStats.addOneOutputStats() in 0.11 also does not recursively iterate and
> code is same as FileBasedOutputSizeReader. Need to investigate where the
> correct value comes from in 0.11 and fix it in 0.12.1/0.13.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
