[
https://issues.apache.org/jira/browse/PIG-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960429#comment-15960429
]
liyunzhang_intel commented on PIG-5215:
---------------------------------------
[~szita] and [~nkollar]:
If have time, please help view this.
1 modification about build.xml in PIG-5215.patch is
{code:java}
index da93cc0..f1bb010 100644
--- a/build.xml
+++ b/build.xml
@@ -262,6 +262,7 @@
<property name="build.ivy.lib.dir" location="${build.ivy.dir}/lib" />
<property name="build.ivy.spark.lib.dir"
location="${build.ivy.dir}/lib/spark" />
<property name="ivy.lib.dir"
location="${build.ivy.lib.dir}/${ant.project.name}"/>
+ <property name="ivy.lib.dir.spark" location="${ivy.lib.dir}/spark" />
<property name="build.ivy.report.dir" location="${build.ivy.dir}/report" />
<property name="build.ivy.maven.dir" location="${build.ivy.dir}/maven" />
<property name="pom.xml" location="${build.ivy.maven.dir}/pom.xml"/>
{code}
in spark branch, the code is
{code:java}
<property name="build.ivy.spark.lib.dir"
location="${build.ivy.dir}/lib/spark" />
{code}
I found that it is interesting that if we set {{build.ivy.spark.lib.dir}} as
build/ivy/lib/Pig/spark,
org.apache.pig.test.TestRegisteredJarVisibility#testRegisterJarOverridePigJarPackages
fail at
[TestRegisteredJarVisibility#L155|https://github.com/apache/pig/blob/308673a782c86cd4bffa330b51e9b8f26a624536/test/org/apache/pig/test/TestRegisteredJarVisibility.java#L155].
While we set {{build.ivy.spark.lib.dir}} as build/ivy/lib/spark, it will not
fail.
> Merge changes from review board to spark branch
> -----------------------------------------------
>
> Key: PIG-5215
> URL: https://issues.apache.org/jira/browse/PIG-5215
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
>
> in [review board|https://reviews.apache.org/r/57317/], there are comments
> from community. After the review board is close, merge these changes to spark
> branch
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
