[
https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961983#comment-15961983
]
Daniel Dai commented on PIG-5211:
---------------------------------
The code changes looks good now. We'd better add several more tests:
1. improve TestOptimizeNestedLimit to translate logical plan to physical plan,
then MR plan, please refer to TestPlanGeneration.testStoreAlias for how to
translate query into logicalplan/physical plan/MR plan
2. add a test to run the query with nested limit sort, to make sure the result
is correct, please refer to TestEvalPipelineLocal for how to run a query and
compare result
3. add a test to TestSecondarySort to make sure nested limited sort is not get
optimized with SecondaryKeyOptimizer
> Optimize Nested Limited Sort
> ----------------------------
>
> Key: PIG-5211
> URL: https://issues.apache.org/jira/browse/PIG-5211
> Project: Pig
> Issue Type: Improvement
> Reporter: Jin Sun
> Assignee: Jin Sun
> Fix For: 0.17.0
>
> Attachments: PIG-5211-1.patch, PIG-5211-2.patch, PIG-5211-3.patch,
> PIG-5211-4.patch
>
>
> Currently in FOREACH clause, if both LIMIT and ORDER BY are present, pig
> stores all elements and sort them. It should use a priority queue to be more
> efficient in space.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
