[
https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966502#comment-15966502
]
Daniel Dai commented on PIG-5216:
---------------------------------
This is a very decent patch. Several comments:
1. I think you also intend to remove TestErrorHandlingStoreFunc.java. This can
be done via "git rm xxx/TestErrorHandlingStoreFunc.java" before generating patch
2.
{code}
public static final String PIG_LOADS = "pig.inputs";
{code}
We'd better change constant into "pig.loads", since the content changes. People
might suspect something wrong if they find "pig.inputs" is different than
expected.
3.
{code}
public static final String ERROR_HANDLER_COUNTER_GROUP = "storer_Error_Handler";
{code}
Make it "Error_Handler"
4. Need some documentation, please refer to PIG-4719, include something similar
to the changes in src/docs/src/documentation/content/xdocs/udf.xml.
> Customizable Error Handling for Loaders in Pig
> ----------------------------------------------
>
> Key: PIG-5216
> URL: https://issues.apache.org/jira/browse/PIG-5216
> Project: Pig
> Issue Type: Improvement
> Reporter: Iris Zeng
> Assignee: Iris Zeng
> Fix For: 0.17.0
>
> Attachments: PIG-5216-1.patch, PIG-5216-2.patch
>
>
> Add Error Handling for Loaders in Pig, so that user can choose to allow
> errors when load data, and set error numbers / rate
> Ideas based on error handling on store func see
> https://issues.apache.org/jira/browse/PIG-4704
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
