[
https://issues.apache.org/jira/browse/PIG-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137892#comment-16137892
]
ASF GitHub Bot commented on PIG-5293:
-------------------------------------
GitHub user lifove opened a pull request:
https://github.com/apache/pig/pull/31
PIG-5293: Add a missing to access a field in a method, reference
Patch for PIG-5293
https://issues.apache.org/jira/browse/PIG-5293
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lifove/pig trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/pig/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 553cf7a5527af3f4d1b669b0c7db3f91ee529ebe
Author: JC <j...@lifove.net>
Date: 2017-08-23T04:48:45Z
PIG-5293: Add a missing to access a field in a method, reference
----
> Suspicious code as missing `this' for a member
> ----------------------------------------------
>
> Key: PIG-5293
> URL: https://issues.apache.org/jira/browse/PIG-5293
> Project: Pig
> Issue Type: Bug
> Reporter: JC
> Assignee: JC
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: trunk
> Path: src/org/apache/pig/pen/util/ExampleTuple.java
> {code:java}
> ...
> 39 Tuple t = null;
> ...
> 110 @Override
> 111 public void reference(Tuple t) {
> 112 t.reference(t);
> 113 }
> {code}
> In Line 112, `t.reference' should be `this.t.reference'? This might be just a
> trivial thing as the class name as ExampleTuple. But I wanted to report just
> in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
