[
https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Noguchi updated PIG-5201:
------------------------------
Attachment: pig-5201-v07.patch
With {{pig-5201-v06.patch}}, saw a couple of unit test failures.
Turns out the change I made in test/Util.java was causing it.
My change was meant to help show the exact output difference when comparisons
fail, but {{checkQueryOutputs}} was calling toString and was incorrectly
failing when comparing two bags with different tuple orders. (Bag is
order-independent, so comparing two bags with different order should still
match.)
{code}
diff --git test/org/apache/pig/test/Util.java test/org/apache/pig/test/Util.java
index 8d4282dfb..f2cec4529 100644
--- test/org/apache/pig/test/Util.java
+++ test/org/apache/pig/test/Util.java
@@ -613,8 +613,7 @@ public class Util {
Collections.sort(actualResList);
Collections.sort(expectedResList);
- Assert.assertEquals("Comparing actual and expected results. ",
- expectedResList, actualResList);
+ checkQueryOutputs(actualResList.iterator(), expectedResList);
}
{code}
Attaching a new patch {{pig-5201-v07.patch}} with change to {{test/Util.java}}
reverted.
> Null handling on FLATTEN
> ------------------------
>
> Key: PIG-5201
> URL: https://issues.apache.org/jira/browse/PIG-5201
> Project: Pig
> Issue Type: Bug
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Fix For: 0.18.0
>
> Attachments: pig-5201-v00-testonly.patch, pig-5201-v01.patch,
> pig-5201-v02.patch, pig-5201-v03.patch, pig-5201-v04.patch,
> pig-5201-v05.patch, pig-5201-v06.patch, pig-5201-v07.patch
>
>
> Sometimes, FLATTEN(null) or FLATTEN(bag-with-null) seem to produce incorrect
> results.
> Test code/script to follow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
