[ https://issues.apache.org/jira/browse/PIG-5343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538726#comment-16538726 ]
Niels Basjes commented on PIG-5343: ----------------------------------- [~szita] In the BUILDING.md is states that these commands must be done for a patch {{ ANT_OPTS='-Djavac.args="-Xlint -Xmaxwarns 1000"'}} {{ ant ${ANT_OPTS} clean piggybank jar compile-test test-commit}} {{ cd contrib/piggybank/java && ant ${ANT_OPTS} test}}{{ }} So I reverted the changes of PIG-5282 and did this. All passes except two that failed because dependencies were introduced that actually need Java 8. I then also did the same with the current Pig (without the -Xmaxwarns 1000) and this patch (i.e. do everything in Java 8) and these also all passed. So the tests everyone runs before submitting a patch all work fine. However when I simply do ant test then apparently a more extensive set of tests is run. There I found that also in the Java 7 setup there are failing tests. The first one that fails in my experiments is the org.apache.pig.builtin.TestOrcStoragePushdown which is also the first one I ran into while working on the mavenization effort. So my current asesment (without doing a complete analysis) is that * There are failing tests under Java 7. * The same tests pass/fail under both Java 7 and Java 8. So this patch (the docker thing) seems correct to me. I created PIG-5348 to handle the problem of these tests separately. > Upgrade developer build environment > ----------------------------------- > > Key: PIG-5343 > URL: https://issues.apache.org/jira/browse/PIG-5343 > Project: Pig > Issue Type: Improvement > Components: build > Reporter: Niels Basjes > Assignee: Niels Basjes > Priority: Major > Attachments: PIG-5343-1.patch, PIG-5343-2.patch, PIG-5343-3.patch > > > The docker image that can be used to setup the build environment still uses > Java 1.7 and is based on a very old version of Ubuntu. > Both of these should be updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)