----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68799/#review209028 -----------------------------------------------------------
test/org/apache/pig/test/TestCredentials.java Lines 128 (patched) <https://reviews.apache.org/r/68799/#comment293293> Can you rename methods as testCredentialsEvalFunc, testCredentialsLoadFunc and testCredentialsStoreFunc? - Rohini Palaniswamy On Sept. 24, 2018, 7:39 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68799/ > ----------------------------------------------------------- > > (Updated Sept. 24, 2018, 7:39 p.m.) > > > Review request for pig. > > > Repository: pig-git > > > Description > ------- > > [PIG-3038] Support for Credentials for UDF,Loader and Storer > > > Diffs > ----- > > src/org/apache/pig/EvalFunc.java fd139a8b4 > src/org/apache/pig/LoadFunc.java 83e89a34c > src/org/apache/pig/StoreFuncInterface.java c590084dc > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > 4d3ab5086 > > src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POUserFunc.java > 2c8dea608 > src/org/apache/pig/backend/hadoop/executionengine/tez/TezDagBuilder.java > f292487f0 > > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/optimizer/LoaderProcessor.java > 7a12df784 > src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java 98040382f > test/org/apache/pig/test/TestCredentials.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/68799/diff/4/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
