codecov-io edited a comment on issue #3671: Make different PinotFS concrete classes have the same behaviors URL: https://github.com/apache/incubator-pinot/pull/3671#issuecomment-452940403 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=h1) Report > Merging [#3671](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/94cab26fa92ffd33a4c5e9502b26a32dde43b914?src=pr&el=desc) will **increase** coverage by `0.25%`. > The diff coverage is `82.08%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3671/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3671 +/- ## ============================================ + Coverage 70.7% 70.95% +0.25% - Complexity 4 44 +40 ============================================ Files 1014 1014 Lines 46520 46564 +44 Branches 6214 6225 +11 ============================================ + Hits 32891 33039 +148 + Misses 11466 11353 -113 - Partials 2163 2172 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...in/java/com/linkedin/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL1Bpbm90RlMuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvU2VnbWVudERlbGV0aW9uTWFuYWdlci5qYXZh) | `80.16% <100%> (+0.82%)` | `0 <0> (ø)` | :arrow_down: | | [...va/com/linkedin/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL0xvY2FsUGlub3RGUy5qYXZh) | `84.84% <33.33%> (-2.66%)` | `0 <0> (ø)` | | | [...a/com/linkedin/pinot/filesystem/HadoopPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtaGFkb29wLWZpbGVzeXN0ZW0vc3JjL21haW4vamF2YS9jb20vbGlua2VkaW4vcGlub3QvZmlsZXN5c3RlbS9IYWRvb3BQaW5vdEZTLmphdmE=) | `70.21% <83.6%> (+70.21%)` | `40 <28> (+40)` | :arrow_up: | | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vQnJva2VyUmVzb3VyY2VWYWxpZGF0aW9uTWFuYWdlci5qYXZh) | `42.1% <0%> (-31.58%)` | `0% <0%> (ø)` | | | [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0VtcHR5QnJva2VyT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | | | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | | | [.../BrokerResourceOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvaGVsaXgvQnJva2VyUmVzb3VyY2VPbmxpbmVPZmZsaW5lU3RhdGVNb2RlbEZhY3RvcnkuamF2YQ==) | `49.15% <0%> (-10.17%)` | `0% <0%> (ø)` | | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vT2ZmbGluZVNlZ21lbnRJbnRlcnZhbENoZWNrZXIuamF2YQ==) | `25.27% <0%> (-5.5%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `72.72% <0%> (-5.46%)` | `0% <0%> (ø)` | | | ... and [25 more](https://codecov.io/gh/apache/incubator-pinot/pull/3671/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=footer). Last update [94cab26...e89f86b](https://codecov.io/gh/apache/incubator-pinot/pull/3671?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org For additional commands, e-mail: dev-h...@pinot.apache.org