akshayrai commented on a change in pull request #3714: [TE] yaml - subscribed
detection names in notification yaml
URL: https://github.com/apache/incubator-pinot/pull/3714#discussion_r249148882
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/yaml/YamlDetectionAlertConfigTranslator.java
##########
@@ -209,15 +185,24 @@ public DetectionAlertConfigDTO
translate(Map<String,Object> yamlAlertConfig) {
alertConfigDTO.setAlertSchemes(buildAlertSchemes(yamlAlertConfig));
alertConfigDTO.setAlertSuppressors(buildAlertSuppressors(yamlAlertConfig));
- alertConfigDTO.setProperties(buildAlerterProperties(yamlAlertConfig));
+ alertConfigDTO.setHighWaterMark(0L);
// NOTE: The below fields will/should be hidden from the YAML/UI. They
will only be updated by the backend pipeline.
- List<Integer> detectionConfigIds =
ConfigUtils.getList(yamlAlertConfig.get(PROP_DETECTION_CONFIG_IDS));
+ List<Long> detectionConfigIds =
ConfigUtils.getLongs(yamlAlertConfig.get(PROP_DETECTION_CONFIG_IDS));
Review comment:
I think we can just remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
