xueyumusic commented on issue #3796: [PINOT-6] Fix Windows compatibility of a batch of pinot-core tests URL: https://github.com/apache/incubator-pinot/pull/3796#issuecomment-462223025 > What triggered adding the close/destroy calls in this PR? Were these from compiler/IDE warnings or from a manual review? Hi, @sunithabeeram , these were run manually `mvn test` on Windows to make tests pass. E.g. some tests's teardown failed caused by non-closed file stream, and some files' path are not Windows compatible.. Thanks
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org For additional commands, e-mail: dev-h...@pinot.apache.org
