Jackie-Jiang commented on a change in pull request #3813: Refactor Hadoop Jobs
URL: https://github.com/apache/incubator-pinot/pull/3813#discussion_r255652621
##########
File path:
pinot-hadoop/src/main/java/org/apache/pinot/hadoop/utils/PushLocation.java
##########
@@ -18,13 +18,25 @@
*/
package org.apache.pinot.hadoop.utils;
+import java.util.ArrayList;
+import java.util.List;
+
+
public class PushLocation {
private final String _host;
private final int _port;
- private PushLocation(PushLocationBuilder pushLocationBuilder) {
- _host = pushLocationBuilder._host;
- _port = pushLocationBuilder._port;
+ public PushLocation(String host, int port) {
Review comment:
Good point. Once we go with official release, these kind of changes need to
be out in multiple steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
