codecov-io commented on issue #3819: Refactor periodic task URL: https://github.com/apache/incubator-pinot/pull/3819#issuecomment-462610714 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=h1) Report > Merging [#3819](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/017e9e555e2db0ec0334d7c3977daef470504298?src=pr&el=desc) will **increase** coverage by `0.1%`. > The diff coverage is `67.12%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3819 +/- ## ========================================== + Coverage 67.1% 67.2% +0.1% Complexity 4 4 ========================================== Files 1027 1027 Lines 50819 50824 +5 Branches 7091 7094 +3 ========================================== + Hits 34102 34158 +56 + Misses 14392 14332 -60 - Partials 2325 2334 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JldGVudGlvbi9SZXRlbnRpb25NYW5hZ2VyLmphdmE=) | `79.16% <ø> (+1.24%)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/common/metrics/ControllerGauge.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyR2F1Z2UuamF2YQ==) | `96% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ller/validation/OfflineSegmentIntervalChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL09mZmxpbmVTZWdtZW50SW50ZXJ2YWxDaGVja2VyLmphdmE=) | `75.58% <ø> (+49.2%)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlbG9jYXRpb24vUmVhbHRpbWVTZWdtZW50UmVsb2NhdG9yLmphdmE=) | `74.72% <0%> (-5.89%)` | `0 <0> (ø)` | | | [...pinot/core/periodictask/PeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wZXJpb2RpY3Rhc2svUGVyaW9kaWNUYXNrU2NoZWR1bGVyLmphdmE=) | `86.11% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...er/validation/BrokerResourceValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL0Jyb2tlclJlc291cmNlVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `81.25% <100%> (+7.56%)` | `0 <0> (ø)` | :arrow_down: | | [...ache/pinot/core/periodictask/BasePeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9wZXJpb2RpY3Rhc2svQmFzZVBlcmlvZGljVGFzay5qYXZh) | `48.43% <42.59%> (-31.57%)` | `0 <0> (ø)` | | | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL21pbmlvbi9QaW5vdFRhc2tNYW5hZ2VyLmphdmE=) | `89.09% <79.31%> (+6.07%)` | `0 <0> (ø)` | :arrow_down: | | [...r/validation/RealtimeSegmentValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci92YWxpZGF0aW9uL1JlYWx0aW1lU2VnbWVudFZhbGlkYXRpb25NYW5hZ2VyLmphdmE=) | `58.33% <80%> (+1.19%)` | `0 <0> (ø)` | :arrow_down: | | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3BlcmlvZGljdGFzay9Db250cm9sbGVyUGVyaW9kaWNUYXNrLmphdmE=) | `81.81% <81.81%> (+13.48%)` | `0 <0> (ø)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/incubator-pinot/pull/3819/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=footer). Last update [017e9e5...08d368e](https://codecov.io/gh/apache/incubator-pinot/pull/3819?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
