jihaozh commented on a change in pull request #3816: [TE] yaml - error messages
URL: https://github.com/apache/incubator-pinot/pull/3816#discussion_r256081094
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionResource.java
##########
@@ -142,7 +142,7 @@ public Response getSubscriptionGroups(@ApiParam("the
detection config id") @Path
List<DetectionAlertConfigDTO> detectionAlertConfigDTOs =
this.detectionAlertConfigDAO.findAll();
Set<DetectionAlertConfigDTO> subscriptionGroupAlertDTOs = new HashSet<>();
for (DetectionAlertConfigDTO alertConfigDTO : detectionAlertConfigDTOs){
- if (alertConfigDTO.getVectorClocks().containsKey(id)){
Review comment:
Not really. I noticed a bug caused by the id missing in the vector clocks.
But the vector clock will be generated automatically from the detection config
id list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@pinot.apache.org
For additional commands, e-mail: dev-h...@pinot.apache.org
